bump: Scala 3.2.2 #31914
Merged
bump: Scala 3.2.2 #31914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Apr 18, 2023
| @@ -23,7 +23,7 @@ jobs: | |||
| # The versions of scala specified here are only used as `+~...` | |||
| # which ignores the PATCH portion of the version id. These Scala versions don't need | |||
| # to be fully defined here then since Akka build handles which patch version will be used. | |||
| scalaVersion: [ "2.12", "2.13", "3.1" ] | |||
| scalaVersion: [ "2.12", "2.13", "3.2" ] | |||
There was a problem hiding this comment.
When we change such versions we must also update the branch protection rules since we have the version in the name (which isn't a great practise for this reason). I have changed it, so just fyi.
"Check / Binary Compatibility (3.2)"
There was a problem hiding this comment.
I think I did that change in exact parallel with you :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As decided in akka/alpakka-kafka#1622 (comment)