feat: Make it possible to define appVersion later #31934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patriknw
commented
May 2, 2023
patriknw
commented
- as alternative to the config app-version that is defined before ActorSystem startup
- if the version is read from an external system (e.g. Kubernetes) this feature makes it possible to define it after system startup but before joining
* as alternative to the config app-version that is defined before ActorSystem startup * if the version is read from an external system (e.g. Kubernetes) this feature makes it possible to define it after system startup but before joining
johanandren
reviewed
May 2, 2023
| None | ||
| case None => | ||
| import akka.pattern.pipe | ||
| // easiest to just try again via JoinTo when the promise has been completed |
There was a problem hiding this comment.
Debug logging or something so it is possible to notice waiting for it is what is going on?
|
merging so that we get a published snapshot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.