Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI/CD badge #31945

Merged
merged 2 commits into from May 23, 2023
Merged

Update CI/CD badge #31945

merged 2 commits into from May 23, 2023

Conversation

akirataguchi115
Copy link
Contributor

Updating the CI/CD badge to 'publish'. Feel free to request changes in this PR for f.ex. a different build than 'publish'.

@lightbend-cla-validator

Hi @akirataguchi115,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@akirataguchi115
Copy link
Contributor Author

signed the cla

@johanandren
Copy link
Member

Thanks, that has been broken a while, I wonder which action is best though, publish only compiles and publishes, but we don't run the pr validation one on main after merge, the nightlies perhaps, but those has the multi node cluster tests which are a bit unstable so it would show non-passing more often than not. Hmmm.

@akirataguchi115
Copy link
Contributor Author

we can also think about what we want to achieve with the build badge on top of the README

@johanandren
Copy link
Member

Yeah, good point, maybe we should just drop it.

@akirataguchi115
Copy link
Contributor Author

sure if it makes the most sense! just lmk if i should remove the badge in this pr

@johanandren
Copy link
Member

Let's drop it, feel free to do it in this PR or we can do it ourselves and close this PR.

@johanandren johanandren merged commit 5f2c598 into akka:main May 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants