Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Drop scalafix plugin #31996

Merged
merged 1 commit into from
Jun 30, 2023
Merged

build: Drop scalafix plugin #31996

merged 1 commit into from
Jun 30, 2023

Conversation

johanandren
Copy link
Member

I don't know that this is anything we use. Around 8000 fewer settings for sbt to deal with on startup with it removed.

References #31986

I don't know that this is anything we use. Around 8000 fewer settings
for sbt to deal with on startup with it removed.
@He-Pin
Copy link
Member

He-Pin commented Jun 29, 2023

IIRC this was imported for scalafix rewriting and the imports sorting.

@patriknw patriknw mentioned this pull request Jun 29, 2023
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorting imports was a good idea, but we never used it frequently enough. We haven't seen slightly unsorted imports to be a problem. We try to use same IDE settings and use that to organize imports.

@leviramsey
Copy link
Contributor

If we ever upgrade scalafmt to a more recent version, that can handle import sorting.

@patriknw
Copy link
Member

Thanks @leviramsey , good to know, and probably a good reason for updating at some point

@patriknw patriknw merged commit 16dde12 into main Jun 30, 2023
6 checks passed
@patriknw patriknw deleted the wip-drop-scalafix branch June 30, 2023 06:39
@patriknw patriknw added this to the 2.8.3 milestone Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants