-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: event writer #32010
feat: event writer #32010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
akka-persistence-typed/src/main/scala/akka/persistence/typed/EventWriter.scala
Outdated
Show resolved
Hide resolved
akka-persistence-typed/src/main/scala/akka/persistence/typed/EventWriter.scala
Outdated
Show resolved
Hide resolved
akka-persistence-typed/src/main/scala/akka/persistence/typed/EventWriter.scala
Outdated
Show resolved
Hide resolved
@patriknw Should I put it in |
sounds good with |
Ready for final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with some minor suggestion
akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/EventWriter.scala
Outdated
Show resolved
Hide resolved
akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/EventWriter.scala
Show resolved
Hide resolved
akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/EventWriter.scala
Outdated
Show resolved
Hide resolved
|
||
Behaviors.receiveMessage { | ||
case Write(persistenceId, sequenceNumber, event, metadata, tags, replyTo) => | ||
val payload = if (tags.isEmpty) event else Tagged(event, tags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.