Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: event writer #32010

Merged
merged 9 commits into from
Jul 7, 2023
Merged

feat: event writer #32010

merged 9 commits into from
Jul 7, 2023

Conversation

johanandren
Copy link
Member

No description provided.

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@johanandren
Copy link
Member Author

@patriknw Should I put it in akka.persistence.typed.internal rather than akka.persistence.typed?

@johanandren johanandren marked this pull request as ready for review July 7, 2023 09:44
@patriknw
Copy link
Member

patriknw commented Jul 7, 2023

sounds good with internal, since that is what it will be

@johanandren
Copy link
Member Author

Ready for final review

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor suggestion


Behaviors.receiveMessage {
case Write(persistenceId, sequenceNumber, event, metadata, tags, replyTo) =>
val payload = if (tags.isEmpty) event else Tagged(event, tags)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johanandren johanandren merged commit 8b29c56 into main Jul 7, 2023
6 checks passed
@johanandren johanandren deleted the wip-event-writer branch July 7, 2023 14:33
@johanandren johanandren added this to the 2.8.4 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants