fix: discard ReceiveTimeout when timeout message is null #32015 #32016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lolboxen, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
octonato
reviewed
Jul 25, 2023
| sealed trait Event | ||
| case object Ended extends Event | ||
|
|
||
| val interval = 1.second |
There was a problem hiding this comment.
this val seems not to be in use
There was a problem hiding this comment.
I think the build will fail because we have a val not in use.
There was a problem hiding this comment.
you are correct, somehow I missed then - even after running the validator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #32015
Approach here is to check if receive message is null and if so stop processing.
Test case may be brittle as it relies on documented behavior but without more advanced knowledge of the project and attempting to test nondeterminism I do not at this time have a better test solution. I welcome suggestions and criticism to make the test case better.