-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+str Add flatmapConcat with parallelism. #32024
Open
He-Pin
wants to merge
1
commit into
akka:main
Choose a base branch
from
He-Pin:flatmapConcatParallelism
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
124 changes: 124 additions & 0 deletions
124
akka-stream-tests/src/test/scala/akka/stream/scaladsl/FlowFlatMapConcatSpec.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,124 @@ | ||
/* | ||
* Copyright (C) 2014-2023 Lightbend Inc. <https://www.lightbend.com> | ||
*/ | ||
|
||
package akka.stream.scaladsl | ||
|
||
import akka.stream.OverflowStrategy | ||
import akka.stream.testkit._ | ||
import akka.stream.testkit.scaladsl.TestSink | ||
|
||
import java.util.concurrent.ThreadLocalRandom | ||
import java.util.concurrent.atomic.AtomicInteger | ||
import scala.concurrent.Future | ||
import scala.concurrent.duration.DurationInt | ||
import scala.util.control.NoStackTrace | ||
|
||
class FlowFlatMapConcatSpec extends StreamSpec(""" | ||
akka.stream.materializer.initial-input-buffer-size = 2 | ||
""") with ScriptedTest { | ||
val toSeq = Flow[Int].grouped(1000).toMat(Sink.head)(Keep.right) | ||
|
||
class BoomException extends RuntimeException("BOOM~~") with NoStackTrace | ||
"A flatMapConcat" must { | ||
|
||
"work with value presented sources" in { | ||
Source( | ||
List( | ||
Source.empty[Int], | ||
Source.single(1), | ||
Source.empty[Int], | ||
Source(List(2, 3, 4)), | ||
Source.future(Future.successful(5)), | ||
Source.lazyFuture(() => Future.successful(6)))) | ||
.flatMapConcat(ThreadLocalRandom.current().nextInt(1, 129), identity) | ||
.runWith(toSeq) | ||
.futureValue should ===(1 to 6) | ||
} | ||
|
||
"work with value presented failed sources" in { | ||
val ex = new BoomException | ||
Source( | ||
List( | ||
Source.empty[Int], | ||
Source.single(1), | ||
Source.empty[Int], | ||
Source(List(2, 3, 4)), | ||
Source.future(Future.failed(ex)), | ||
Source.lazyFuture(() => Future.successful(5)))) | ||
.flatMapConcat(ThreadLocalRandom.current().nextInt(1, 129), identity) | ||
.onErrorComplete[BoomException]() | ||
.runWith(toSeq) | ||
.futureValue should ===(1 to 4) | ||
} | ||
|
||
"work with value presented sources when demands slow" in { | ||
val prob = Source( | ||
List(Source.empty[Int], Source.single(1), Source(List(2, 3, 4)), Source.lazyFuture(() => Future.successful(5)))) | ||
.flatMapConcat(ThreadLocalRandom.current().nextInt(1, 129), identity) | ||
.runWith(TestSink()) | ||
|
||
prob.request(1) | ||
prob.expectNext(1) | ||
prob.expectNoMessage(1.seconds) | ||
prob.request(2) | ||
prob.expectNext(2, 3) | ||
prob.expectNoMessage(1.seconds) | ||
prob.request(2) | ||
prob.expectNext(4, 5) | ||
prob.expectComplete() | ||
} | ||
|
||
"can do pre materialization when parallelism > 1" in { | ||
val materializationCounter = new AtomicInteger(0) | ||
val randomParallelism = ThreadLocalRandom.current().nextInt(4, 65) | ||
val prob = Source(1 to (randomParallelism * 3)) | ||
.flatMapConcat( | ||
randomParallelism, | ||
value => { | ||
Source | ||
.lazySingle(() => { | ||
materializationCounter.incrementAndGet() | ||
value | ||
}) | ||
.buffer(1, overflowStrategy = OverflowStrategy.backpressure) | ||
}) | ||
.runWith(TestSink()) | ||
|
||
expectNoMessage(1.seconds) | ||
materializationCounter.get() shouldBe 0 | ||
|
||
prob.request(1) | ||
prob.expectNext(1.seconds, 1) | ||
expectNoMessage(1.seconds) | ||
materializationCounter.get() shouldBe (randomParallelism + 1) | ||
materializationCounter.set(0) | ||
|
||
prob.request(2) | ||
prob.expectNextN(List(2, 3)) | ||
expectNoMessage(1.seconds) | ||
materializationCounter.get() shouldBe 2 | ||
materializationCounter.set(0) | ||
|
||
prob.request(randomParallelism - 3) | ||
prob.expectNextN(4 to randomParallelism) | ||
expectNoMessage(1.seconds) | ||
materializationCounter.get() shouldBe (randomParallelism - 3) | ||
materializationCounter.set(0) | ||
|
||
prob.request(randomParallelism) | ||
prob.expectNextN(randomParallelism + 1 to randomParallelism * 2) | ||
expectNoMessage(1.seconds) | ||
materializationCounter.get() shouldBe randomParallelism | ||
materializationCounter.set(0) | ||
|
||
prob.request(randomParallelism) | ||
prob.expectNextN(randomParallelism * 2 + 1 to randomParallelism * 3) | ||
expectNoMessage(1.seconds) | ||
materializationCounter.get() shouldBe 0 | ||
prob.expectComplete() | ||
} | ||
|
||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random is good for trying it out while developing but means that we'd have no idea what value it fails for if it fails. Parameterize over a few values or use a single random chosen and logged on test class instantiation instead, so failures can be repeated.