Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove info log showing Slf4jLogger started to avoid slf4j warning at the top #31395 #32039

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove info log showing Slf4jLogger started to avoid slf4j warning at the top #31395 #32039

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17a30a7
have a tiny buffer for slf4j to get initialized #31395
dongxuwang Aug 15, 2023
8663af5
remove log which showing Slf4jLogger started to get slf4j warning sil…
dongxuwang Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion akka-slf4j/src/main/scala/akka/event/slf4j/Slf4jLogger.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ class Slf4jLogger extends Actor with SLF4JLogging with RequiresMessageQueue[Logg
}

case InitializeLogger(_) =>
log.info("Slf4jLogger started")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should anyway touch the log because that is a lazy val and if we don't touch it we haven't really started the intiialization yet, and next real log message will do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about let Slf4jLogger NOT to extend SLF4JLogging

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be fine, but it would still have to create the logger at some point.

Well, there is a problem with compatibility if removing SLF4JLogging, because Slf4jLogger is public api and not final. Someone may have extended it and expect that log.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's also another point.

sender() ! LoggerInitialized
}

Expand Down