feat: Predefined marker interfaces for JSON and CBOR #32049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
force-pushed
the
wip-predefine-jackson-markers
branch
from
5f1777b
to
f36cd57
Compare
patriknw
reviewed
Aug 18, 2023
There was a problem hiding this comment.
Yeah, I'm not sure why we don't have those. I think it's good, and removes that boilerplate step of adding your own. We must have considered it in the original implementation because we had it in Lagom, but I can't find any memories or comments about it. Closest might be #26870 (comment)
Anyway, go ahead, can't hurt. There is also docs that should be updated.
patriknw
reviewed
Aug 18, 2023
|
Had indeed missed two markers in tests, but those already had the same package as the new ones, so just dropping those should be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or is there a good reason we don't ship such @patriknw ?