fix: additional mailbox selector method on Props #32082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Sep 1, 2023
akka-actor-typed-tests/src/test/scala/akka/actor/typed/DispatcherSpec.scala
Outdated
Show resolved
Hide resolved
akka-actor-typed/src/main/scala/akka/actor/typed/internal/adapter/PropsAdapter.scala
Outdated
Show resolved
Hide resolved
Roiocam
commented
Sep 1, 2023
patriknw
reviewed
Sep 4, 2023
akka-actor-typed-tests/src/test/scala/akka/actor/typed/DispatcherSelectorSpec.scala
Outdated
Show resolved
Hide resolved
patriknw
reviewed
Sep 8, 2023
akka-actor-typed-tests/src/test/scala/akka/actor/typed/DispatcherSelectorSpec.scala
Outdated
Show resolved
Hide resolved
akka-actor-typed-tests/src/test/scala/akka/actor/typed/DispatcherSelectorSpec.scala
Outdated
Show resolved
Hide resolved
akka-actor-typed-tests/src/test/scala/akka/actor/typed/DispatcherSelectorSpec.scala
Outdated
Show resolved
Hide resolved
akka-actor-typed-tests/src/test/scala/akka/actor/typed/DispatcherSelectorSpec.scala
Outdated
Show resolved
Hide resolved
Roiocam
commented
Sep 10, 2023
| parentProbe.ref) | ||
|
|
||
| val childProbe = createTestProbe[ActorRef[Ping]]() | ||
| grandParent ! SpawnProtocol.Spawn(PingPong(), "child", Props.empty.withDispatcherSameAsParent, childProbe.ref) |
There was a problem hiding this comment.
It seems that the 'parent' and 'child' do not spawn with a vertical hierarchy, but rather a horizontal hierarchy.
There was a problem hiding this comment.
yes, seems to be a mistake, it's spawning from grandParent twice
Roiocam
changed the title
patriknw
approved these changes
Sep 12, 2023
| parentProbe.ref) | ||
|
|
||
| val childProbe = createTestProbe[ActorRef[Ping]]() | ||
| grandParent ! SpawnProtocol.Spawn(PingPong(), "child", Props.empty.withDispatcherSameAsParent, childProbe.ref) |
There was a problem hiding this comment.
yes, seems to be a mistake, it's spawning from grandParent twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #31862
Returning an empty mailbox is not a problem in PropsAdapter.