Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Drop Scala 2.12 #32125

Merged
merged 2 commits into from Sep 21, 2023
Merged

chore: Drop Scala 2.12 #32125

merged 2 commits into from Sep 21, 2023

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Sep 21, 2023 •
edited

See also #32126

johanandren
johanandren approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We'll have to remove the required check for 2.12 in the repo settings as well.

@patriknw
Copy link
Member Author

I changed the branch protection rules

@patriknw patriknw merged commit 1e829b0 into main Sep 21, 2023
5 checks passed
@patriknw patriknw deleted the wip-drop-scala-2.12-patriknw branch September 21, 2023 14:36
@patriknw patriknw added this to the 2.9.0-M2 milestone Sep 21, 2023
This was referenced Sep 22, 2023
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 2, 2023
Merged
Merged
Merged
Merged
@SethTisue SethTisue mentioned this pull request Jan 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
dependency-change
Projects
None yet
Milestone
2.9.0-M2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patriknw @johanandren