Make sure ActorContext.ask compile with multiple parameters (#26514) #32174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Oct 13, 2023
...sharding-typed/src/test/scala/akka/cluster/sharding/typed/scaladsl/ClusterShardingSpec.scala
Show resolved
Hide resolved
Captain1653
force-pushed
the
remove-code-related-to-26514
branch
from
c385ac0
to
ff2e825
Compare
Captain1653
changed the title
johanandren
approved these changes
Oct 13, 2023
patriknw
reviewed
Oct 13, 2023
...sharding-typed/src/test/scala/akka/cluster/sharding/typed/scaladsl/ClusterShardingSpec.scala
Outdated
Show resolved
Hide resolved
Captain1653
force-pushed
the
remove-code-related-to-26514
branch
from
ff2e825
to
98983ba
Compare
|
Thanks for fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #26514
Issue was closed four years ago, but this code is still here.
I think it can be removed. It was done before changing params in ActorContext.ask .
I can do something like that
Should I do it? I'm not sure.
Kind regards