Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify example code of reliable delivery #32199

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

Roiocam
Copy link
Contributor

@Roiocam Roiocam commented Oct 23, 2023

Motivation

In the original "ask" case, there was some ambiguity about where the stashBuffer was obtained from. This PR makes the code in that case more complete, and the code of Work pulling case will not any changes.

Before

截屏2023-10-23 14 30 01

After

截屏2023-10-23 14 29 21

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@johanandren johanandren merged commit 70b2b95 into akka:main Nov 8, 2023
5 checks passed
@johanandren johanandren added this to the 2.9.1 milestone Nov 8, 2023
He-Pin pushed a commit to He-Pin/akka that referenced this pull request Jan 7, 2024
@Roiocam Roiocam deleted the rd-doc-ask-example branch February 20, 2024 01:50
@Roiocam Roiocam restored the rd-doc-ask-example branch February 20, 2024 02:09
@Roiocam Roiocam deleted the rd-doc-ask-example branch February 20, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants