Remove unnecessary todo from DurableStateStoreRegistry #32207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Captain1653
force-pushed
the
remove-unnecessary-todo-durable-state-store-registry
branch
from
b8fe017
to
d175fd8
Compare
|
@johanandren Can it be reviewed? Please ) |
|
@patriknw was this just a left over or something to actually deal with? |
patriknw
approved these changes
Nov 10, 2023
| @@ -85,9 +85,7 @@ class DurableStateStoreRegistry(system: ExtendedActorSystem) | |||
| * Java API: Returns the [[akka.persistence.state.javadsl.DurableStateStore]] specified by the given | |||
| * configuration entry. | |||
| */ | |||
| final def getDurableStateStoreFor[T <: javadsl.DurableStateStore[_]]( | |||
| @unused clazz: Class[T], // FIXME generic Class could be problematic in Java | |||
There was a problem hiding this comment.
I think it was related to that in Java you can't easily create/get a Class with a generic parameter. E.g. this would not work:
Class<DurableStateStoreQuery<Record>> durableStateStoreQueryClass = DurableStateStoreQuery.class;
We get away by using this in the doc sampel:
DurableStateStoreQuery<Record> durableStateStoreQuery =
DurableStateStoreRegistry.get(system)
.getDurableStateStoreFor(DurableStateStoreQuery.class, pluginId);
That is an untyped warning, but probably fine.
Captain1653
deleted the
remove-unnecessary-todo-durable-state-store-registry
branch
He-Pin
pushed a commit
to He-Pin/akka
that referenced
this pull request
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little suggestion :) .
I was checking todo items in the project and found this.
This code was created in this PR. This PR is related to #30277 . This issue was released 2 years ago.
Should this todo be removed?