Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Simpler old-version-warning #32215

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

johanandren
Copy link
Member

Copied from Alpakka, uses an injected project version from the build to determine its own version, and picks up https://doc.akka.io/docs/akka/current/paradox.json (also generated at build) to determine current latest version, so no longer depends on updating the http://akka.io/versions.json for each release.

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, same is needed in akka-http

@johanandren johanandren merged commit 87505a1 into main Oct 31, 2023
5 checks passed
@johanandren johanandren deleted the wip-simpler-warn-old-versions-in-docs branch October 31, 2023 13:42
@johanandren
Copy link
Member Author

For the record I manually patched the live older akka and akka-http versions on gustav, needed a slightly different JS because no injected self-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants