build: Add JDK 21 to nightly builds #32226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvlugter
approved these changes
Nov 7, 2023
|
Huh, coursier in the CI job doesn't find temurin:1.21.0.1, but I can download that on my local machine using coursier. 🤔 |
|
Green test run here: https://github.com/akka/akka/actions/runs/6796437075 |
octonato
approved these changes
Nov 8, 2023
octonato
reviewed
Nov 8, 2023
| @@ -88,6 +88,7 @@ jobs: | |||
| # leaving out some combinations (note that `build-test-prValidations.yml` doesn't run all test | |||
| - { scalaVersion: "2.13", jdkVersion: "1.11.0", jvmName: "temurin:1.11.0", extraOpts: '' } | |||
| - { scalaVersion: "2.13", jdkVersion: "1.17.0", jvmName: "temurin:1.17.0", extraOpts: '' } | |||
| - { scalaVersion: "2.13", jdkVersion: "1.21.0", jvmName: "temurin:1.21", extraOpts: '' } | |||
There was a problem hiding this comment.
btw, PR validation is still using jdk11.
Maybe time to move to jdk17 and keep jdk11 only in the nightly build?
There was a problem hiding this comment.
I think it is good to keep the oldest as default because then we catch if a PR uses new JDK (and Scala) stdlib issues directly instead of not until the nightlies.
Not sure if it is worth it with one more build for JDK 21 or not.
There was a problem hiding this comment.
I'll merge and we can follow up adding Scala 3 JDK 21 to the matrix if we decide we want it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.