Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fill gaps in EventWriter via message instead of config #32237

Merged
merged 2 commits into from
Nov 28, 2023
Merged

feat: Fill gaps in EventWriter via message instead of config #32237

merged 2 commits into from
Nov 28, 2023

Conversation

patriknw
Copy link
Member

  • makes it possible to use same EventWriter for both types of producers
  • and we don't need to document that the config has to be set

@patriknw
feat: Fill gaps in EventWriter via message instead of config
8790785 
* makes it possible to use same EventWriter for both types of producers
* and we don't need to document that the config has to be set
@patriknw patriknw mentioned this pull request Nov 23, 2023
Merged
pvlugter
pvlugter approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/EventWriter.scala Outdated
state.copy(waitingForSeqNrLookup = state.waitingForSeqNrLookup :+ ((repr, replyTo)))
state.copy(
waitingForSeqNrLookup = state.waitingForSeqNrLookup :+ ((repr, replyTo)),
fillSequenceNumberGaps = newFillSequenceNumberGaps || state.fillSequenceNumberGaps)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need || state.fillSequenceNumberGaps here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, that was already done in newFillSequenceNumberGaps

@patriknw patriknw merged commit 82586be into main Nov 28, 2023
5 checks passed
@patriknw patriknw deleted the wip-fill-gaps2-patriknw branch November 28, 2023 10:28
@patriknw patriknw added this to the 2.9.1 milestone Nov 28, 2023
He-Pin pushed a commit to He-Pin/akka that referenced this pull request Jan 7, 2024
@patriknw @He-Pin
feat: Fill gaps in EventWriter via message instead of config (akka#32237
d69c910 
)

* makes it possible to use same EventWriter for both types of producers
* and we don't need to document that the config has to be set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvlugter pvlugter pvlugter approved these changes

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patriknw @pvlugter @johanandren