feat: Cache piercing for discovery and async-dns #32260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
commented
Dec 15, 2023
| @@ -74,12 +74,18 @@ class SimpleDnsCache extends Dns with PeriodicCacheCleanup with NoSerializationV | |||
| } | |||
|
|
|||
| @tailrec | |||
| private[io] final def put(key: (String, RequestType), records: Resolved, ttl: CachePolicy): Unit = { | |||
| private[akka] final def put(key: (String, RequestType), records: Resolved, ttl: CachePolicy): Unit = { | |||
There was a problem hiding this comment.
Opened up slightly to be able to write test in discovery
johanandren
deleted the
wip-cache-piercing-for-discover-and-async-dns
branch
|
I'm wondering if an alternative approach of setting a maximum DNS TTL would be conceptually cleaner than exposing a drop operation on the cache through service discovery? |
|
This is not intended as general purpose but a means for a specific downstream feature in Akka gRPC for discovering updated sets of services to load balance over. Forcing all cache to be dropped for that purpose seems wasteful and would also not be enough for that feature since we also need the drop to trigger a refreshed list to push into the gRPC client. |
|
For the record, this is the Akka gRPC functionality PR: akka/akka-grpc#1886 |
He-Pin
pushed a commit
to He-Pin/akka
that referenced
this pull request
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to programatically force re-resolution even if TTL is long, needed downstream in Akka gRPC for periodic refresh of nodes used for client side load balancing.