fix: JoinConfigChecker and Scala 3 #32323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One classpath scanned entry was anonoymous and encoded to different names on Scala 2.13 and Scala 3, so making it an actual class to keep the name stable.
johanandren
commented
Feb 21, 2024
| @@ -47,7 +47,7 @@ | |||
| "name" : "<init>" | |||
| } ] | |||
| }, { | |||
| "name" : "akka.cluster.JoinConfigCompatChecker$$anon$1", | |||
There was a problem hiding this comment.
would be $anon$2 on Scala 3 so tests could never pass on both 2.13 and 3
johanandren
deleted the
wip-fix-native-image-join-config-checker-scala-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One classpath scanned entry was anonoymous and encoded to different names on Scala 2.13 and Scala 3, so making it an actual class to keep the name stable.
This particular implementation is actually never reflectively created, but filtering it would require adding a new capability to native-image classpath scanning just for this problem so took the shorter path to fix it.