chore: Provide logback native-image metadata out of the box #32327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible out of the box
|
I just realized this will not work, the user never interacts directly with the logback APIs, they are only reflectively loaded and used by us, so the |
|
Oh, but it did somehow work: https://github.com/akka/akka/actions/runs/8016537721/job/21898648151 |
patriknw
reviewed
Feb 23, 2024
There was a problem hiding this comment.
nice if this works, see also https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-with-GraalVM#logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we use logback-classic in all our quickstarts and samples, optional reflection metadata is convenient for users.