bump: scala-library 2.13.13 (was 2.13.12) #32354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
reviewed
Mar 21, 2024
| timeout, | ||
| system.scheduler() | ||
| ); | ||
|
|
||
| CompletionStage<ActorRef<AllKindsOfMusic>> musicListener = AskPattern.ask( | ||
| system, | ||
| replyTo -> new Spawn(Listener.create(), "musicListener", Props.empty(), replyTo), | ||
| replyTo -> new Spawn<>(Listener.create(), "musicListener", Props.empty(), replyTo), |
There was a problem hiding this comment.
Unrelated Java compiler warning fixes
johanandren
reviewed
Mar 21, 2024
| .receivePartial[Command] { | ||
| case (context, Pong) => | ||
| .receiveMessagePartial[Command] { | ||
| case Pong => |
There was a problem hiding this comment.
This is the new same-name-used-in-surrounding-scope warning (context in this case)
johanandren
reviewed
Mar 21, 2024
| @@ -66,7 +66,8 @@ private[akka] object ActorRefAdapter { | |||
| case internal.Unwatch(watchee, watcher) => | |||
| classicRef.sendSystemMessage(sysmsg.Unwatch(toClassic(watchee), toClassic(watcher))) | |||
| case internal.DeathWatchNotification(ref, _) => | |||
| classicRef.sendSystemMessage(sysmsg.DeathWatchNotification(toClassic(ref), true, false)) | |||
| classicRef.sendSystemMessage( | |||
| sysmsg.DeathWatchNotification(toClassic(ref), existenceConfirmed = true, addressTerminated = false)) | |||
There was a problem hiding this comment.
boolean parameters require name or cause warning
|
Best with another core team review here as I changed quite a bit of things |
|
Have not look into the code, but the next 2.13.14 release will make the named boolean just a warning. |
|
It is a warning, but we build with |
Yeah, but you can turn it off too, if you like, as you already done all the changes, so 👍👍👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
📦 Updates org.scala-lang:scala-library from
2.13.12to2.13.13📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: