Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to be consistent with listing below #32362

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

michalkoza
Copy link
Contributor

The listing just below includes / as well so I figure the language should be three here

@lightbend-cla-validator

Hi @michalkoza,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@@ -35,7 +35,7 @@ As we covered in the @scala[[Quickstart Guide](https://developer.lightbend.com/g

![actor tree diagram](diagrams/actor_top_tree.png)

In fact, before your first actor is started, Akka has already created two actors in the system. The names of these built-in actors contain _guardian_. The guardian actors include:
In fact, before your first actor is started, Akka has already created three actors in the system. The names of these built-in actors contain _guardian_. The guardian actors include:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With typed, the user actor "your first" is the user guardian, so the two that are started before it is the root guardian and the system guardian, so two here is correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha! how about rephrasing it then like this?

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement, thanks!

@johanandren johanandren merged commit aedec1b into akka:main Mar 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants