Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Include more samples #32387

Merged
merged 1 commit into from
Apr 18, 2024
Merged

doc: Include more samples #32387

merged 1 commit into from
Apr 18, 2024

Conversation

patriknw
Copy link
Member

On top of #32384

run: |-
cd samples/akka-sample-kafka-to-sharding-scala
sbt test -Dakka.version=`cat ~/.version`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following are not moved (and will not have a replacement):

  • akka-sample-cluster-client-grpc-java
  • akka-sample-cluster-client-grpc-scala
  • akka-sample-cqrs-java
  • akka-sample-cqrs-scala
  • akka-sample-distributed-workers-scala
  • akka-sample-persistence-dc-java
  • akka-sample-persistence-dc-scala
  • akka-sample-persistence-java
  • akka-sample-persistence-scala

@@ -33,11 +29,6 @@ You can use both Akka remoting and Akka Cluster inside Docker containers. Note
that you will need to take special care with the network configuration when using Docker,
described here: @ref:[Akka behind NAT or in a Docker container](../remoting-artery.md#remote-configuration-nat-artery)

You can look at the
@java[@extref[Cluster with docker-compse example project](samples:akka-sample-cluster-docker-compose-java)]
@scala[@extref[Cluster with docker-compose example project](samples:akka-sample-cluster-docker-compose-scala)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not worth keeping that sample

@@ -13,10 +13,6 @@ To take advantage of running inside Kubernetes while forming a cluster,
@extref:[Akka Cluster Bootstrap](akka-management:bootstrap/) helps forming or joining a cluster using Akka Discovery to discover peer nodes.
with the Kubernetes API or Kubernetes via DNS.

You can look at the
@extref[Cluster with Kubernetes example project](samples:akka-sample-cluster-kubernetes-java)
to see what this looks like in practice.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be included in "Deploying Akka Cluster to Kubernetes", which is linked above

Base automatically changed from wip-quickstart-patriknw to main April 17, 2024 14:04
* move samples from https://github.com/akka/akka-samples
  and include zip files in docs
@patriknw patriknw marked this pull request as ready for review April 17, 2024 14:06
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw merged commit 3273f98 into main Apr 18, 2024
5 checks passed
@patriknw patriknw deleted the wip-more-samples-patriknw branch April 18, 2024 13:41
@patriknw patriknw added this to the 2.9.3 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants