Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirement failed message in 0.11-M4 #189

Closed
xelax opened this issue Aug 10, 2016 · 10 comments
Closed

requirement failed message in 0.11-M4 #189

xelax opened this issue Aug 10, 2016 · 10 comments

Comments

@xelax
Copy link

xelax commented Aug 10, 2016

While running 0.11-M4 I've got this error:

2016-08-10 10:10:50,056 ERROR a.a.OneForOneStrategy - requirement failed
java.lang.IllegalArgumentException: requirement failed
at scala.Predef$.require(Predef.scala:212)
at akka.kafka.KafkaConsumerActor.poll(KafkaConsumerActor.scala:182)
at akka.kafka.KafkaConsumerActor$$anonfun$receive$1.applyOrElse(KafkaConsumerActor.scala:101)
at akka.actor.Actor$class.aroundReceive(Actor.scala:484)
at akka.kafka.KafkaConsumerActor.aroundReceive(KafkaConsumerActor.scala:56)
at akka.actor.ActorCell.receiveMessage(ActorCell.scala:526)
at akka.actor.ActorCell.invoke(ActorCell.scala:495)
at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:257)
at akka.dispatch.Mailbox.run(Mailbox.scala:224)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)

@xelax xelax changed the title requirement failed in requirement failed message in 0.11-M4 Aug 10, 2016
@kciesielski
Copy link
Contributor

kciesielski commented Aug 10, 2016

Can you reproduce this error somehow? It is caused by internal .poll() call returning messages for different partitions than expected. It would be good to have a failing test for this.

@xelax
Copy link
Author

xelax commented Aug 10, 2016

I got it when I had 3 different instances of a listener on the same queue and then I kill one of them, and I see the error in the console of the other one. I will try to see whether I can trigger this reliably.

@kciesielski
Copy link
Contributor

Thanks, @xelax

@13h3r I suspect that consumer assignment changed before poll() (https://github.com/akka/reactive-kafka/blob/master/core/src/main/scala/akka/kafka/KafkaConsumerActor.scala#L167) hence poll returned more than expected, WDYT?

@xelax
Copy link
Author

xelax commented Aug 10, 2016

Yes, it sounds likely to me, besides my listeners are getting updates in large batches with few thousands of largish messages in them, so it is quite possible that while getting the messages the consumer assignment get changed.

@13h3r
Copy link
Member

13h3r commented Aug 11, 2016

@xelax did you use auto or manual partition assignment assignment?

@kciesielski How assignment may be changed before poll? And how it may broke the code?

@13h3r
Copy link
Member

13h3r commented Aug 11, 2016

Please try build from master. Looks like #179 fixes this

@kciesielski
Copy link
Contributor

@13h3r It can be changed by rebalance, but as you pointed to #179 I can see now that pause will be called, so it should be properly handled.

@13h3r
Copy link
Member

13h3r commented Aug 15, 2016

Could you check it? //@xelax

@xelax
Copy link
Author

xelax commented Aug 15, 2016

sorry, was out on vacation last week. I will build and try it out today or tomorrow.
thanks!

On Aug 15, 2016, at 8:52 AM, Alexey Romanchuk notifications@github.com wrote:

Could you check it? //@xelax https://github.com/xelax

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #189 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AAav9IBylSl_XuhwNPQwf8hRQtlOo7nbks5qgIstgaJpZM4JhXoz.

@xelax
Copy link
Author

xelax commented Aug 16, 2016

I tried it out with the new build and the problem seems to be solved.

@13h3r 13h3r closed this as completed Aug 16, 2016
@ennru ennru added this to the invalid milestone Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants