Added withHeader(s) withProperty(-ies) and withoutDestination methods… #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WellingR
force-pushed
the
feature/useful-overloads
branch
from
fce7708
to
c96d5dd
Compare
|
I added some MiMa problem filters because of the newly added methods, did I add these in the right place? |
2m
reviewed
Jul 18, 2019
| ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.stream.alpakka.jms.JmsMessage.withHeaders") | ||
| ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.stream.alpakka.jms.JmsMessage.withProperties") | ||
| ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.stream.alpakka.jms.JmsMessage.withHeader") | ||
| ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.stream.alpakka.jms.JmsMessage.withoutDestination") |
There was a problem hiding this comment.
These have to go to a separate file named by the latest released, so 1.1.0.backwards.excludes
… to the JmsMessage trait.
WellingR
force-pushed
the
feature/useful-overloads
branch
from
c96d5dd
to
e949a62
Compare
2m
approved these changes
Aug 1, 2019
|
One question, this is now targeted for 2.0, however this PR is actually backwards binary compatible, but not forwards binary compatible. Or do I get this wrong? The only difference with #1752, is that this PR also adds methods to the |
|
We now start merging things for Alpakka 2.0 after the 1.1.1 release. |
ennru
pushed a commit
to ennru/alpakka
that referenced
this pull request
Oct 9, 2019
…thods to the JmsMessage trait. (akka#1830)
|
Backported for 1.1.2 with #1974 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition to the functionality added to #1752 the withProperties method is now available on the
JmsMessagetrait, as well as withHeaders and withDestination.All these methods are implemented such that the subtypes return their own subtype. E.g.
JmsTextMessage.withPropertiespreviously returnedJmsTextMessagePassThrough[NotUsed]instead ofJmsTextMessage