Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added withHeader(s) withProperty(-ies) and withoutDestination methods… #1830

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

WellingR
Copy link
Member

This is an addition to the functionality added to #1752 the withProperties method is now available on the JmsMessage trait, as well as withHeaders and withDestination.

All these methods are implemented such that the subtypes return their own subtype. E.g. JmsTextMessage.withProperties previously returned JmsTextMessagePassThrough[NotUsed] instead of JmsTextMessage

@WellingR
Copy link
Member Author

I added some MiMa problem filters because of the newly added methods, did I add these in the right place?

ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.stream.alpakka.jms.JmsMessage.withHeaders")
ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.stream.alpakka.jms.JmsMessage.withProperties")
ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.stream.alpakka.jms.JmsMessage.withHeader")
ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.stream.alpakka.jms.JmsMessage.withoutDestination")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have to go to a separate file named by the latest released, so 1.1.0.backwards.excludes

Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets schedule this for the upcoming 2.0.

@2m 2m added this to the 2.0.0 milestone Aug 1, 2019
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@WellingR
Copy link
Member Author

WellingR commented Aug 8, 2019

One question, this is now targeted for 2.0, however this PR is actually backwards binary compatible, but not forwards binary compatible. Or do I get this wrong?

The only difference with #1752, is that this PR also adds methods to the sealed trait JmsMessage. But as the trait is sealed, can this incompatibility really be a problem?

@ennru ennru merged commit 5c6796b into akka:master Aug 9, 2019
@ennru
Copy link
Member

ennru commented Aug 9, 2019

We now start merging things for Alpakka 2.0 after the 1.1.1 release.
Thank you for adding this!

ennru pushed a commit to ennru/alpakka that referenced this pull request Oct 9, 2019
@ennru
Copy link
Member

ennru commented Oct 9, 2019

Backported for 1.1.2 with #1974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants