XML: add support for supplying XMLInputFactory configuration #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault of secure processing #1943
ennru
reviewed
Oct 11, 2019
There was a problem hiding this comment.
The binary-compatibilty check didn't like the new method.
https://travis-ci.com/akka/alpakka/jobs/244263285#L690
You need to add it to be excluded from those checks by adding a MiMa filter file "1.1.2.backwards.excludes".
xml/src/main/scala/akka/stream/alpakka/xml/impl/StreamingXmlParser.scala
Show resolved
Hide resolved
ennru
approved these changes
Oct 15, 2019
xml/src/main/scala/akka/stream/alpakka/xml/impl/StreamingXmlParser.scala
Show resolved
Hide resolved
|
Thank you for hanging in here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds support to pass in a configure function for configuring the XMLInputFactory used by XmlParsing
References
References #1943
Changes
Background Context