Slick: factory method SlickSession.forDbAndProfile #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added the method SlickSession.forDbAndProfile(db: JdbcBackend#Database, profile: JdbcProfile)
* Moved the method SlickSession.forDbAndProfile(db: JdbcBackend#Database, profile: JdbcProfile) to the scaladsl version of SlickSession, as slick offers no good Java API for creating a Database instance. * Created abstract class SlickSessionFactory, and letting both the javadsl and scaladsl version of SlickSession object extends it, to avoid duplicating the shared factory methods. * Made the unit test for the factory method close the connection it creates, and the end of the test. * Added documentation about the new way of creating a SlickSession instance.
|
You need to add MiMa exclusions in a file |
* Added line for ignoring akka.stream.alpakka.slick.javadsl.SlickSession$SlickSessionImpl.
* Added line for ignoring akka.stream.alpakka.slick.scaladsl.package.SlickSession.
|
Done, thanks for the hint. |
ennru
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Introduces an extra factory method for creating a SlickSession out of Slick Database and Profile instances.
References
References #1509
Changes
Background Context
It makes it possible to create a SlickSession, if you starting point is a Slick Database instance. This can be the case, when working with other libraries, that are based on Slick, but now nothing about Alpakka. In my case, it was a test library, that provides each test, with its own test database, provided as a Slick Database instance.