Unix domain socket: upgrade dependencies; remove classifier #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
dependency-change
huntc
reviewed
Jan 27, 2020
| @@ -440,8 +440,8 @@ object Dependencies { | |||
|
|
|||
| val UnixDomainSocket = Seq( | |||
| libraryDependencies ++= Seq( | |||
| "com.github.jnr" % "jffi" % "1.2.17" classifier "complete", // ApacheV2 | |||
There was a problem hiding this comment.
Unsure if the classifier is still required. It certainly used to be. What’s the downside of having it still?
There was a problem hiding this comment.
My immediate problem is that it (with Coursier) breaks the Whitesource reporting.
There was a problem hiding this comment.
Coursier has problems with artifacts, see e.g. sbt/sbt#5325 (and the linked issues there as well).
There was a problem hiding this comment.
The testsuite in this branch runs fine for me locally.
|
Might be related to this issue in sbt-whitesource lightbend/sbt-whitesource#58 |
27 tasks
ennru
force-pushed
the
unix-domain-socket-upgrades
branch
from
e0e8394
to
f3e337d
Compare
seglo
approved these changes
Feb 10, 2020
|
@huntc I'll merge this now, please reach out in case you run into problems without the dependency classifier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Upgrade to later versions of "jiffi" and "jnr-unixsocket" and remove the classifier on "jiffi".
References
The classifier puts sbt-whitesource off https://travis-ci.com/akka/alpakka/jobs/280329800#L356
Background Context
I'm not sure if the classifier is needed anymore. It works locally on OSX for me.