-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unix domain socket: upgrade dependencies; remove classifier #2108
Conversation
@@ -440,8 +440,8 @@ object Dependencies { | |||
|
|||
val UnixDomainSocket = Seq( | |||
libraryDependencies ++= Seq( | |||
"com.github.jnr" % "jffi" % "1.2.17" classifier "complete", // ApacheV2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure if the classifier is still required. It certainly used to be. What’s the downside of having it still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My immediate problem is that it (with Coursier) breaks the Whitesource reporting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coursier has problems with artifacts, see e.g. sbt/sbt#5325 (and the linked issues there as well).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The testsuite in this branch runs fine for me locally.
Might be related to this issue in sbt-whitesource lightbend/sbt-whitesource#58 |
e0e8394
to
f3e337d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It would be nice to confirm upstream if this classifier is required, but it doesn't seem to be necessary to run our testsuite.
@huntc I'll merge this now, please reach out in case you run into problems without the dependency classifier. |
Purpose
Upgrade to later versions of "jiffi" and "jnr-unixsocket" and remove the classifier on "jiffi".
References
The classifier puts sbt-whitesource off https://travis-ci.com/akka/alpakka/jobs/280329800#L356
Background Context
I'm not sure if the classifier is needed anymore. It works locally on OSX for me.