UnixDomainSocketTest: await domain socket binding before connecting #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old test didn't do what it said it did: binding to a file that does not exist yet is perfectly fine, but this test would fail on typical systems because the user would not have permissions to write to /. Changed it to a non-existent directory so it'll fail even when you're allowed to write to /. To test the original intent of the test we could create a file/directory that we don't have permissions to write to, but that's for another PR.
raboof
added a commit
that referenced
this pull request
Feb 4, 2020
This would have made #2129 more obvious, checking the stream result is good practice so we should lead by example.
raboof
added a commit
that referenced
this pull request
Feb 5, 2020
This would have made #2129 more obvious, checking the stream result is good practice so we should lead by example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #2128