AWS S3: Allow source keys with non-ASCII characters #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpdn
changed the title
ennru
reviewed
Apr 24, 2020
s3/src/test/scala/akka/stream/alpakka/s3/scaladsl/S3IntegrationSpec.scala
Outdated
Show resolved
Hide resolved
Co-Authored-By: Enno <458526+ennru@users.noreply.github.com>
|
Some tests fail because of this change as the |
|
I corrected HttpRequestSpec to assume urlencoded keys. Alternatively, we could have chosen not to urlencode |
|
Please run |
|
There is another test failure |
|
That seems odd. I suspect that might actually be a bug in MinIO as it seems like the space is causing problems. Anyway, just removing the space makes the test work at least. Alpakka still supports more characters than before, and AFAIK this should work against S3. |
ennru
changed the title
|
Thank you, great fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing URL encoding for source keys when copying.