Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json-streaming: fix generated POM #2344

Merged
merged 1 commit into from
Jun 11, 2020
Merged

json-streaming: fix generated POM #2344

merged 1 commit into from
Jun 11, 2020

Conversation

laszlovandenhoek
Copy link
Contributor

Removes the explicit dependency on jsurfer, which is of type pom, but is implicitly specified as being of type jar in the generated POM for alpakka-json-streaming, making the latter unusable from Maven (#2338).

@probot-autolabeler probot-autolabeler bot added the dependency-change For PRs changing the version of a dependency. label Jun 11, 2020
ennru
ennru approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru added this to the 2.0.2 milestone Jun 11, 2020
@ennru ennru changed the title #2338: fix generated POM for json-streaming json-streaming: fix generated POM Jun 11, 2020
@ennru ennru merged commit 72c85b7 into akka:master Jun 11, 2020
@ennru
Copy link
Member

ennru commented Jun 11, 2020

Thank you for noticing and solving it!

@ennru ennru mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
dependency-change For PRs changing the version of a dependency. p:json-streaming
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@laszlovandenhoek @ennru