S3: Add access-style property #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laszlovandenhoek
changed the title
laszlovandenhoek
force-pushed
the
access-style
branch
from
e5af13b
to
025bbef
Compare
laszlovandenhoek
force-pushed
the
access-style
branch
3 times, most recently
from
639acb6
to
e402d13
Compare
laszlovandenhoek
force-pushed
the
access-style
branch
from
e402d13
to
408ff41
Compare
|
Thank you for suggesting and providing a clean solution to this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #2171 . In the pull request #2193 (comment) it was noted that it would be better to have a separate
access-styleproperty instead of the current tripartitepath-style-accessone. This PR attempts to improve that situation.With this change,
access-styleis the preferred way of setting the property, using eitherpathorvirtual.If the old, deprecated
path-style-accessis used, that takes precedence, but a warning is logged to instruct the developer to change to the new property.If the effective access style is
path, andendpoint-urlis not set (i.e. the S3 provider is AWS), one warning is issued. This is not configurable, but it shouldn't have to be, because using path-style access on AWS S3 is likely going to cause problems sooner or later.