S3: Consider not deprecating path-style access

[mpdn]

While AWS is deprecating path-style access, many other providers of S3-like services are not. Path-style access is usually the easiest way to setup MinIO as it does not require fudging around with the DNS.

So while path-style access for AWS should be deprecated, path-style access for custom endpoints are still relevant.

For the same reason, it would be nice to have a way to disable the warning here:

alpakka/s3/src/main/scala/akka/stream/alpakka/s3/impl/HttpRequests.scala

Line 179 in 4c01bb1

"AWS S3 is going to retire path-style access (https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/)"

I would be willing to put some work into this. The simplest way of achieving this would probably be something like un-deprecating the withPathStyleAccess function and remove the warning for custom endpoints.

[ennru]

You are right, for compatible storage solutions Alpakka should continue to allow path-style access in one way or the other.

Would it be possible to use the enpoint-url setting to achieve something without removing the deprecation?

alpakka/s3/src/main/resources/reference.conf

Lines 87 to 91 in 01bb7e4

	# Custom endpoint url, used for alternate s3 implementations
	# To enable virtual-host-style access with Alpakka S3 use the placeholder `{bucket}` in the URL
	# eg. endpoint-url = "http://{bucket}.s3minio.alpakka:9000"
	#
	# endpoint-url = null

[KGausel]

@ennru I tried that, but maybe I configured it wrong. Do you have any input on how to make it work with MinIO using the endpoint-url template method you are suggesting?

I tried http://myminio.local/{bucket} and http://myminio.local/{bucket}/

[ennru]

Alpakka uses Minio with virtual-host style access. The trick is to configure a forward-proxy and a dynamic enpoint-url:

alpakka/s3/src/test/scala/akka/stream/alpakka/s3/scaladsl/S3IntegrationSpec.scala

Lines 638 to 657 in 63b22cb

	override def attributes(s3Settings: S3Settings): Attributes = {
	S3Attributes.settings(
	s3Settings
	.withForwardProxy(
	ForwardProxy.http("localhost", 9000)
	)
	)
	}
	it should "properly set the endpointUrl" in {
	S3Settings().endpointUrl.value shouldEqual endpointUrlVirtualHostStyle
	}
	}
	object MinioS3IntegrationSpec {
	val accessKey = "TESTKEY"
	val secret = "TESTSECRET"
	val endpointUrlPathStyle = "http://localhost:9000"
	val localMinioDomain = "s3minio.alpakka"
	val endpointUrlVirtualHostStyle = s"http://{bucket}.$localMinioDomain:9000"

[KGausel]

This might not be an option for all users though and seems like an overly complicated way to stop Alpakka from spamming log warnings of path style access being deprecated.

[ennru]

@KGausel Good news, @laszlovandenhoek just convinced me that we can should [re-think the path-style access settings](#2193 (comment)

[ennru]

With #2392 the deprecation shows only if you don't use an endpointUrl thus use AWS' services.
This cleaner solution resolved your request.