Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3: Add method to delete bucket contents #2406

Merged
merged 1 commit into from
Sep 16, 2020
Merged

S3: Add method to delete bucket contents #2406

merged 1 commit into from
Sep 16, 2020

Conversation

mas15
Copy link
Contributor

@mas15 mas15 commented Sep 14, 2020

Using S3.deleteObjectsByPrefix("bucket", None) looks a bit odd.

@lightbend-cla-validator
Copy link

Hi @mas15,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

ennru
ennru reviewed Sep 16, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Could you please add it to the Java-DSL S3, as well?

ennru
ennru approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru added this to the 2.0.2 milestone Sep 16, 2020
@ennru ennru changed the title Add helper method to delete bucket contents S3: Add method to delete bucket contents Sep 16, 2020
@ennru ennru merged commit 9039d58 into akka:master Sep 16, 2020
@ennru
Copy link
Member

ennru commented Sep 16, 2020

Thank you, expect a release very soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
p:aws-s3
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mas15 @lightbend-cla-validator @ennru