BigQuery API improvements #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
changed the title
seglo
approved these changes
May 12, 2021
| */ | ||
| final case class JobConfiguration(load: Option[JobConfigurationLoad]) { | ||
| final case class JobConfiguration(load: Option[JobConfigurationLoad], labels: Option[Map[String, String]]) { |
There was a problem hiding this comment.
We could make this constructor private to avoid breaking change, I guess? Not a big deal.
There was a problem hiding this comment.
Not sure if that would help? I think we need to add a constructor with the old signature. I should have marked all of these constructors private to begin with...
There was a problem hiding this comment.
Let's make it private and just add the MimaException. It won't be bin compat but since you added the factory method it should be code compat for the Scala DSL at least.
There was a problem hiding this comment.
Sounds good. While I'm at it, can I mark all the other case class constructors private?
|
I will open a separate PR #2665 to enable MiMa for google-common. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JobConfigurationandinsertAllAsync. Not 100% binary compatible to 3.0.0-M1 because of case class stuff, but if important can probably be fixed?Schemasingleton object to help materialize implicitTableSchemafor a classT