Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure FTP connection intermittently fails #365

Closed
raboof opened this issue Jun 27, 2017 · 6 comments · Fixed by #366 or #373
Closed

Secure FTP connection intermittently fails #365

raboof opened this issue Jun 27, 2017 · 6 comments · Fixed by #366 or #373
Labels
Milestone

Comments

@raboof
Copy link
Member

raboof commented Jun 27, 2017

We use version 0.1.54 of jsch, which appears to contain a bug that is triggered since jdk 1.8.0_121.

We're impacted by this as shown by the test failures tracked in #361.

It looks like we'll either have to move away from jsch, wait for the bug to be fixed there, or help them fix it.

@raboof raboof added the bug label Jun 27, 2017
raboof added a commit that referenced this issue Jun 27, 2017
To reduce test flakiness until we fix #365
@raboof
Copy link
Member Author

raboof commented Jun 27, 2017

Hmm jsch seems quite dead, perhaps we should consider moving to another library anyway, for example https://github.com/hierynomus/sshj

@raboof
Copy link
Member Author

raboof commented Jun 28, 2017

Pinging past ftp module contributors: @svezfaz @juanjovazquez @argast @nktpro @eharik @rafacm @neowulf33 - this bug seems to be triggered quite a lot on recent openjdk versions, anyone up to taking a look?

@juanjovazquez
Copy link

@raboof I'll try to have a look into it ASAP. We should probably assess moving away from jsch.

@charego
Copy link

charego commented Aug 31, 2017

Have you seen this issue since changing libraries? Personally I have seen the exception with sshj.
hierynomus/sshj#354

@raboof
Copy link
Member Author

raboof commented Aug 31, 2017

@charlesrgould that's interesting, we haven't seen it since switching to sshj - but that doesn't mean it is gone of course, as it was intermittent to begin with. At least sshj is actively maintained so if there's anything to fix there's a chance of fixing it there :).

@hierynomus
Copy link

@raboof And you even know the maintainer ;) Happy to work with you to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment