1117/s3 dl mtd future should fail when request fails #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jypma
reviewed
Jul 23, 2018
| val source = Source | ||
| .fromFuture(future.flatMap(entityForSuccess).map(_._1)) |
There was a problem hiding this comment.
I don't see what's changing here. Aren't you just changing val future to include flatMap(entityForSuccess), rather than doing it in-line in the source declaration?
There was a problem hiding this comment.
@jypma , this affects the error handling for the object metadata future as well, it will now fail on failed responses (i.e.404)
There was a problem hiding this comment.
Ahh I see. So the effect of the change is not here, but in the line 103 which maps future which now has error handling because of the added .flatMap(entityForSuccess).
|
Awesome. Thanks for the fix! |
sebastianharko
pushed a commit
to sebastianharko/alpakka
that referenced
this pull request
Sep 5, 2018
* 1117: fix the issue by extracting errors before looking at the returned headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #1117,
the future returned by S3Stream.download should fail when the underlying request to aws s3 fails (i.e. with a 404).
this PR first modified an existing test to check the future (in addition to the source) for failure, then it introduces a fix.