Elasticsearch: towards 1.0 #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ennru Based on your comments, I think this looks good |
* Moved implementation to `impl` * Un-case-classed settings * Renamed `ElasticsearchSinkSettings` to `ElasticSearchWriteSettings` API CHANGES
ennru
force-pushed
the
ennru_es-towards-1.0
branch
from
0b39f75
to
4551937
Compare
2m
approved these changes
Sep 18, 2018
| def getId: String = id | ||
|
|
||
| /** Java API */ | ||
| def getSource: T = source |
There was a problem hiding this comment.
Unnecessary getter for Java since the types are java-friendly.
| val success: Boolean = error.isEmpty | ||
|
|
||
| /** Java API */ | ||
| def getMessage: WriteMessage[T2, C2] = message |
ennru
force-pushed
the
ennru_es-towards-1.0
branch
from
2cfc570
to
e8166a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major API changes
IncomingMessageWriteMessage(non case class)IncomingIndexMessageWriteMessage.createIndexMessageIncomingUpdateMessageWriteMessage.createUpdateMessageIncomingUpsertMessageWriteMessage.createUpsertMessageIncomingDeleteMessageWriteMessage.createDeleteMessageIncomingMessageResultWriteResultOutgoingMessageReadResultElasticsearchSinkSettingsis now calledElasticsearchWriteSettingsand no case class anymore. The fields to specify retrying are replaced byRetryLogicwith the two implementationsRetryNever(default) andRetryAtFixedRate.ElasticsearchSourceSettingsis no case class anymore.To support implementing stream elements created by the Elasticsearch stages,
akka.stream.alpakka.elasticsearch.testkit.MessageFactoryoffers factory methods.Fixes #1070