AWS S3: add cacheControl to ObjectMetadata #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtjeferreira
commented
Oct 17, 2018
| @@ -132,7 +139,7 @@ final class ObjectMetadata private ( | |||
| * @see ObjectMetadata#setContentType(String) | |||
| */ | |||
| lazy val contentType: Option[String] = metadata.collectFirst { | |||
| case h if h.lowercaseName() == "content-type" => h.value | |||
| case ct: `Content-Type` => ct.value | |||
There was a problem hiding this comment.
Following the boy scout rule, I improved this.
There are several Content-Type classes: akka.http.scaladsl.model.ContentType, akka.http.scaladsl.model.headers.Content-Length and before #858 we were using the wrong one...
2m
reviewed
Oct 17, 2018
| * Gets the optional Cache-Control header | ||
| */ | ||
| def getCacheControl: Optional[String] = | ||
| scalaMetadata.cacheControl.fold(Optional.empty[String]())(Optional.of) |
There was a problem hiding this comment.
There is asJava method in the scala-java8-compat library which is already pulled in here by akka-actor: https://github.com/scala/scala-java8-compat#usage-example
There was a problem hiding this comment.
I used asJava in other occurrences of this pattern...
2m
reviewed
Oct 17, 2018
| * Gets the optional Cache-Control header | ||
| */ | ||
| lazy val cacheControl: Option[String] = metadata.collectFirst { | ||
| case c: `Cache-Control` => c.value() |
There was a problem hiding this comment.
Above, we call value without parenthesis. We should make it consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.