Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Kinesis: Better error for GetShardIteratorFailure #1484

Merged
merged 6 commits into from Feb 10, 2019

Conversation

denisgarci
Copy link
Contributor

Pull Request Checklist

Purpose

When using akka-stream-alpakka-elasticsearch and akka-stream-alpakka-kinesis in the same project, the following error will get swallowed:

Exception in thread "main" java.util.concurrent.ExecutionException: com.amazonaws.SdkClientException: Unable to marshall request to JSON: Jackson jackson-core/jackson-dataformat-cbor incompatible library version detected.
You have two possible resolutions:
		1) Ensure the com.fasterxml.jackson.core:jackson-core & com.fasterxml.jackson.dataformat:jackson-dataformat-cbor libraries on your classpath have the same version number
		2) Disable CBOR wire-protocol by passing the -Dcom.amazonaws.sdk.disableCbor property or setting the AWS_CBOR_DISABLE environment variable (warning this may affect performance)

log.error("Failed to get a shard iterator for shard {}", shardId)
log.error(ex.getMessage)
Copy link
Member

@2m 2m Feb 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding an additional logging statement, we should pass in the exception to the above statement:

log.error(ex, "Failed ...", shardId)

Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM!

@2m 2m merged commit 96e9419 into akka:master Feb 10, 2019
@2m 2m added the p:kinesis label Feb 10, 2019
@2m 2m added this to the 1.0-M3 milestone Feb 10, 2019
@denisgarci
Copy link
Contributor Author

Thank you for the help!

@denisgarci denisgarci deleted the kinesis-better-err branch February 10, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants