-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MongoDB: Towards Alpakka 1.0 #1514
Conversation
Added missing Java tests and documentation updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions about the API.
mongodb/src/main/scala/akka/stream/alpakka/mongodb/javadsl/MongoFlow.scala
Outdated
Show resolved
Hide resolved
mongodb/src/main/scala/akka/stream/alpakka/mongodb/javadsl/MongoFlow.scala
Outdated
Show resolved
Hide resolved
mongodb/src/main/scala/akka/stream/alpakka/mongodb/javadsl/MongoSink.scala
Show resolved
Hide resolved
64f9ee6
to
687614d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great to get a Java API!
Hi @ennru and @2m , I just realised that with this PR you removed all my work from original MongoDB connector and replaced it with some other library implementation. You guys opened the issue #1082 and without getting any reviews, @2m deleted whole implementation and replaced it and @ennru accepted the PR again without getting any community views. You didn't even mentioned or tag people to get notice. Why would I contribute anything if you are going to remove it in future at will? Congrats! Decent community work! |
This was before my time, but I believe the intention was only to re-use new functionality that was available in the upstream Mongo driver that I assume wasn't available when the connector was first implemented/donated to Alpakka. Since using the reactivestreams implementation significantly reduced the surface area of this connector it was easier to bring the Java DSL up to par at the same time, which is a requirement of all Alpakka connectors so they can be used by the Java community at large with the same features as the Scala community. I'm certain there was no ill will about the original implementation! |
Hi @iozozturk |
Fixes
Fixes #1082
Purpose
Adds javadsl for API parity.
Background Context
To reuse the implementation, MongoDB connector was switched from scala MongoDB driver to the Reactive Streams one.
BSON construction API can still be used from the scala driver, but that jar will need to be pulled in separately, as it is done in tests.
Missing