Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB: Towards Alpakka 1.0 #1514

Merged
merged 11 commits into from
Feb 21, 2019
Merged

MongoDB: Towards Alpakka 1.0 #1514

merged 11 commits into from
Feb 21, 2019

Conversation

2m
Copy link
Member

@2m 2m commented Feb 19, 2019

Fixes

Fixes #1082

Purpose

Adds javadsl for API parity.

Background Context

To reuse the implementation, MongoDB connector was switched from scala MongoDB driver to the Reactive Streams one.

BSON construction API can still be used from the scala driver, but that jar will need to be pulled in separately, as it is done in tests.

Missing

  • doc updates
  • javadsl sink tests

@ennru ennru added this to the 1.0-M3 milestone Feb 19, 2019
@2m 2m changed the title WIP: MongoDB: Towards Alpakka 1.0 MongoDB: Towards Alpakka 1.0 Feb 19, 2019
@2m
Copy link
Member Author

2m commented Feb 19, 2019

Added missing Java tests and documentation updates.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions about the API.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great to get a Java API!

@2m 2m merged commit f00c420 into akka:master Feb 21, 2019
@2m 2m deleted the wip-mongodb-1.0-2m branch February 21, 2019 15:36
@iozozturk
Copy link
Contributor

Hi @ennru and @2m , I just realised that with this PR you removed all my work from original MongoDB connector and replaced it with some other library implementation. You guys opened the issue #1082 and without getting any reviews, @2m deleted whole implementation and replaced it and @ennru accepted the PR again without getting any community views. You didn't even mentioned or tag people to get notice. Why would I contribute anything if you are going to remove it in future at will?

Congrats! Decent community work!

@seglo
Copy link
Member

seglo commented Jan 6, 2020

This was before my time, but I believe the intention was only to re-use new functionality that was available in the upstream Mongo driver that I assume wasn't available when the connector was first implemented/donated to Alpakka.

Since using the reactivestreams implementation significantly reduced the surface area of this connector it was easier to bring the Java DSL up to par at the same time, which is a requirement of all Alpakka connectors so they can be used by the Java community at large with the same features as the Scala community.

I'm certain there was no ill will about the original implementation!

@ennru
Copy link
Member

ennru commented Jan 13, 2020

Hi @iozozturk
Sorry if we didn't live up to the expectations you have for how open source should be managed.
We are still grateful that you kicked off the Alpakka MongoDB connector back in 2017 with #148. As reported in #494 there was no API for Java users and our ambition is to offer somewhat similar APIs for both Scala and Java.
So for Alpakka 1.0 we wanted to have the Java DSL as #1082 stated in July 2018. We've seen very little community engagement around Alpakka MongoDB (which I believe is partly due to ReactiveMongo being a great choice for Scala users) so that's why @2m as member of Lightbend's Alpakka team implemented it in February 2019 on top of the Reactive Streams compatible MongoDB driver.
It was never the intention to remove the code you contributed, this was just a step to make Alpakka MongoDB attractive for more users.
Sorry, that we did not explicitly reached out to you when we worked on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MongoDB: become Alpakka 1.0 ready
4 participants