Elasticsearch: Make flows type signature simpler to prepare for withContext
#1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2m
approved these changes
Feb 20, 2019
| @@ -118,15 +118,15 @@ Java | |||
|
|
|||
| | Parameter | Default | Description | | |||
| | ------------------- | ------- | ------------------------------------------------------------------------------------------------------ | | |||
| | bufferSize | 10 | `ElasticsearchSink` puts messages by one bulk request per messages of this buffer size. | | |||
| | bufferSize | 10 | Flow and Sink batche messages to bulk requests when back-pressure applies. | | |||
There was a problem hiding this comment.
Suggested change
| | bufferSize | 10 | Flow and Sink batche messages to bulk requests when back-pressure applies. | | |
| | bufferSize | 10 | Flow and Sink batch messages to bulk requests when back-pressure applies. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Change Elasticsearch flow signatures to single element flows.
Background Context
Akka has introduced a new type of flow
withContextwhich supportspassThroughs to be passed hidden from the user.Elasticsearch flows used to do have internal logic for batching which made them consume
WriteMessages but emitSeq[WriteResult]s which does not work together with context promotion.The retry logic in
ElasticsearchFlowStagedoes not work with context promotion, either.This ended up in a major rewrite of
ElasticsearchFlowStage.References
akka/akka#25951