Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add java getter to Datagram #1803

Merged
merged 1 commit into from Jul 2, 2019
Merged

Add java getter to Datagram #1803

merged 1 commit into from Jul 2, 2019

Conversation

2m
Copy link
Member

@2m 2m commented Jul 2, 2019

Purpose

Adds conventional Java API getters to Datagram.

References

Fixes #1768

@2m 2m added the p:udp label Jul 2, 2019
@2m 2m added this to the 1.1.0 milestone Jul 2, 2019
ennru
ennru approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit 482d834 into akka:master Jul 2, 2019
@2m 2m deleted the wip-udp-java-getter-2m branch July 2, 2019 13:38
cheleb pushed a commit to cheleb/alpakka that referenced this pull request Jul 5, 2019
@2m @cheleb
UDP: Add java getters to Datagram (akka#1803)
e8bc214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
p:udp
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Need getter method for data in Alpakka UDP Datagram
2 participants
@2m @ennru