Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document PubAck handling #1908

Draft
wants to merge 2 commits into
base: master
from

Conversation

@huntc
Copy link
Contributor

commented Aug 30, 2019

This attempts to improve the doc around how to back-pressure the publication of Publish commands to avoid buffer overflow in QoS 1+ cases.

I'm looking for feedback as to whether this helps explain things, particularly given problems like this: https://discuss.lightbend.com/t/alpakka-mqtt-streaming-performance-problem/4913.

TODO:

  • Provide Java sample
Document PubAck handling
This improves the doc around how to back-pressure the publication of Publish commands to avoid buffer overflow in QoS 1+ cases.
@ennru

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

Yes, this helps. That scanning is not what I'd want to have every user to add to their code. That's definitely something I'd like to wrap into the convenience API, I've been experimenting with a while ago: #1565
Doing this from Java will be even harder to read...

@huntc

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

In the case of publishing from a client, I think that we can provide the equivalent to the ask pattern where a Future[Done] is returned. This is in addition to the tell we already have.

I do think that specific cases like client publishing can be made more convenient.

WDYT?

@huntc

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

In the case of publishing from a client, I think that we can provide the equivalent to the ask pattern where a Future[Done] is returned. This is in addition to the tell we already have.

I do think that specific cases like client publishing can be made more convenient.

Here's what the ask pattern may look like: https://github.com/akka/alpakka/pull/1908/files#diff-57b7cf48120d900f9398000d526e9854R70

Thoughts @ennru ?

@ennru

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Yes, that would be great and feel consistent with the tell/ask in Akka Actors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.