Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS S3: discard entity on failed sign request #2001

Merged
merged 2 commits into from
Nov 7, 2019
Merged

AWS S3: discard entity on failed sign request #2001

merged 2 commits into from
Nov 7, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Nov 7, 2019

Purpose

Ensure the HTTP response entity data is discarded when a signing response fails.

Changes

  • discard entity data in signAndRequest
  • change Javadsl listBucket to use Optional instead of scala.Option (old methods deprecated)
  • add shutdown of Actor System and WireMock in S3Test
  • upgrade WireMock to 2.25.1 and adapt empty request mocking

@probot-autolabeler probot-autolabeler bot added dependency-change For PRs changing the version of a dependency. p:aws-s3 labels Nov 7, 2019
@ennru ennru added this to the 2.0.0-M1 milestone Nov 7, 2019
@seglo
Copy link
Member

seglo commented Nov 7, 2019

Some failures from other projects

#1801
#2003 (first observation)
#1649

seglo
seglo approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seglo seglo merged commit 5f40572 into akka:master Nov 7, 2019
@ennru ennru deleted the s3-warnings branch April 21, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seglo seglo seglo approved these changes

Assignees
No one assigned
Labels
dependency-change For PRs changing the version of a dependency. p:aws-s3 to-be-backported
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ennru @seglo