Use silencer plugin params only in Compile configuration #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The fix in #2077 was able to progress the Alpakka master publishing a step further, but then fails again when the silencer exemption is not available for during the
publishtask itself. After consulting with @eed3si9n I found a cleaner universal fix that should resolve this issue once and for all.References
Changes
Use silencer parameters in all
Compileconfigurations only. Omitintaskin scoping so it applies to all tasks and remove previous workaround to filter out parameters for thedoctask specifically.