New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avroparquet: Lower bound higher kinded #2273
Conversation
I have noticed that it breaks the site creation with paradox, once I got some feedback I would fix that by creating a new test to support that. |
cb895ab
to
8b096d3
Compare
Thank you for this PR. I rebased it (as we had some problem with tests not running), fixed Paradox and added the required Mima exclusions. Please improve the docs and examples to show that you may use a more specific type than Generic Record now. We plan to release Alpakka 2.0 next week, it would be great to get this in. |
Have pushed the changes, note that I have only added a scala example that will demonstrate the improvement, and I have explicitly mentioned that in the documentation. I think that for the time being this is a good improvement, but still could be even better to completely erase the type constrain on Sadly I have not the time to implement it at that moment, but I will in the future if no one does... that would also imply a wider test coverage as well as renaming the whole sub-module. |
Thank you, I've pushed some updates as I'd like to see the PR for the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hello!
There is no issue related with this PR.
While looking at how to implement protobuf parquet connector, I realised that the current implementation of avroparquet was statically typead as
GenericRecord
, which for the Akka user is not nice.On continuation with that the tests were simplified and improved by not just checking the number of records written but also the actual content of the file.