Added a source that doesn't automatically ACK messages to rabbit #291 #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refs #97 |
ndriscoll
reviewed
May 12, 2017
There was a problem hiding this comment.
I think there should be a way to parameterize the AmqpSourceStage on the message type (already Acked or not) to try to cut down on the duplication. Will think about it more.
FWIW, if it wouldn't break other things, I think AckedIncomingMessage and IncomingMessage are clearer than IncomingMessage and IncomingMessageWithAck, respectively (like instead of saying you can ack it, reverse it and say what is right now IncomingMessage has already been Acked)
| /** | ||
| * Connects to an AMQP server upon materialization and consumes messages from it emitting them | ||
| * into the stream. Each materialized source will create one connection to the broker. | ||
| * As soon as an `IncomingMessage` is sent downstream, an ack for it is sent to the broker. |
build.sbt
Outdated
| .settings( | ||
| name := "akka-stream-alpakka-amqp", | ||
| version := "0.5.3-sigfig", |
Changes Amqp sinks to materialize to Future[Done]. As currently it was very difficult to determine when/if a sink failed due to a amqp error.
|
Closing this as it was superseded by #483 that just got merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some parts of this that I'm not sure about. Specifically the implementation of Ack and Nack being subclasses of an arbitrary Command function.